Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip over already-seen blobs when generating Bazel targets. #66

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

captainreality
Copy link
Contributor

@captainreality captainreality commented Sep 16, 2024

When using the -shallow=False flag, multiple targets with the same name were being generated, which Bazel does not like. This commit ensures we only generate one Bazel target per blob.

When using the -shallow flag, multiple targets with the same name
were being generated, which Bazel does not like. This commit
ensures we only generate one Bazel rule per blob.
@captainreality captainreality marked this pull request as ready for review September 16, 2024 21:21
@captainreality captainreality merged commit dc34711 into main Oct 22, 2024
2 checks passed
@captainreality captainreality deleted the kim.mason/too-many-blobs branch October 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants