-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add process discovery tests #3981
base: main
Are you sure you want to change the base?
Conversation
1c745f9
to
d8295c0
Compare
d8295c0
to
4789a86
Compare
manifests/php.yml
Outdated
@@ -420,6 +420,7 @@ tests/: | |||
test_context_propagation.py: | |||
Test_Otel_Context_Propagation_Default_Propagator_Api: incomplete_test_app (endpoint not implemented) | |||
parametric/: | |||
test_process_discovery.py: missing_feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keys must be ordered, this line should go few lines below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a tool to automate that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not 😞
It in our backlog, but lack of ressource ... #1722
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫠 I'll write the tool tomorrow then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a ton of off the shelf tools for this, eg https://github.com/marketplace/actions/yaml-lint
For the above, we could use mostly default settings and enable the key-ordering rule
https://yamllint.readthedocs.io/en/stable/configuration.html#default-configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be awesome ❤️ . I've precised in the issue what to do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, @cbeauchesne, I’ve decided to step away from writing the formatter due to more pressing priorities. At first I thought it would be as straightforward as calling a yaml formatter but the order requirement makes it more involved. Additionally, I find the order requirements to be primarily aesthetic and somewhat unclear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bm1549 is tacking the format/lint in #4077 🥳
Additionally, I find the order requirements to be primarily aesthetic and somewhat unclear.
The only reason for this requirements is to help people editing a lot manifests files: it helps finding a key. Though, I'm not attached at all to this requirements (i almost never edit those files). You can propose to remove this requirements on slack on #apm-shared-testing.
Motivation
Test process discovery feature. RFC
Changes
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present