Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add process discovery tests #3981

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dmehala
Copy link
Contributor

@dmehala dmehala commented Feb 4, 2025

Motivation

Test process discovery feature. RFC

Changes

  • Add a new parametric test.
  • Update parametric tests internal.

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@dmehala dmehala force-pushed the dmehala/process-discovery-feature branch 2 times, most recently from 1c745f9 to d8295c0 Compare February 11, 2025 10:58
@dmehala dmehala force-pushed the dmehala/process-discovery-feature branch from d8295c0 to 4789a86 Compare February 11, 2025 11:10
@dmehala dmehala marked this pull request as ready for review February 11, 2025 15:23
@dmehala dmehala requested review from a team and mabdinur as code owners February 11, 2025 15:23
@dmehala dmehala requested review from lievan, jandro996, Mariovido and mcculls and removed request for a team February 11, 2025 15:23
@@ -420,6 +420,7 @@ tests/:
test_context_propagation.py:
Test_Otel_Context_Propagation_Default_Propagator_Api: incomplete_test_app (endpoint not implemented)
parametric/:
test_process_discovery.py: missing_feature
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keys must be ordered, this line should go few lines below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a tool to automate that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not 😞

It in our backlog, but lack of ressource ... #1722

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫠 I'll write the tool tomorrow then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a ton of off the shelf tools for this, eg https://github.com/marketplace/actions/yaml-lint

For the above, we could use mostly default settings and enable the key-ordering rule
https://yamllint.readthedocs.io/en/stable/configuration.html#default-configuration

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be awesome ❤️ . I've precised in the issue what to do

Copy link
Contributor Author

@dmehala dmehala Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, @cbeauchesne, I’ve decided to step away from writing the formatter due to more pressing priorities. At first I thought it would be as straightforward as calling a yaml formatter but the order requirement makes it more involved. Additionally, I find the order requirements to be primarily aesthetic and somewhat unclear.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bm1549 is tacking the format/lint in #4077 🥳

Additionally, I find the order requirements to be primarily aesthetic and somewhat unclear.

The only reason for this requirements is to help people editing a lot manifests files: it helps finding a key. Though, I'm not attached at all to this requirements (i almost never edit those files). You can propose to remove this requirements on slack on #apm-shared-testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants