Add MOSAIC, ARCRC, SENSO, ADCAD, SALMON expand query expansion rules #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoeba
changed the title
amoeba
changed the title
amoeba
changed the title
amoeba
added a commit
that referenced
this pull request
Aug 12, 2022
Ref #31 Also adds tests for previously added MOSAiC and ARCRC ontologies
This adds support for transitive and symmetric skos:exactMatch and non-transitive but symmetric skos:closeMatch
amoeba
force-pushed
the
feature-29-add-mosiac-and-arcrc
branch
from
9cbcdbe to
f7ef529
Compare
amoeba
changed the title
|
This PR now includes support for all ontologies we've been developing for the last while and is ready to get merged @taojing2002. This closes #29. Before or after merge, these changes need to get cherry-picked onto https://github.com/DataONEorg/dataone-indexer and also ported to https://github.com/NCEAS/metacat. All content in CN and MN Solr instances matching the query |
amoeba
added a commit
to DataONEorg/dataone-indexer
that referenced
this pull request
Aug 12, 2022
This was referenced Aug 12, 2022
taojing2002
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @taojing2002, this adds indexing support for two new ontologies we've developed over on https://github.com/DataONEorg/sem-prov-ontologies for #29 and also tweaks some of the indexing logic described in DataONEorg/dataone-indexer#3.
The PR includes automated tests and I've done a fair bit of manual testing so this doesn't need an in-depth review, though I'd appreciate you taking a quick look.
Closes #29 and DataONEorg/dataone-indexer#3.