refreshSession, deleteSession #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will also implement deleteSession, refreshSession (refreshSession should revoke the old session token, right?) |
|
New plan:
general question: what's the point of having session tokens and refresh tokens being separate things? |
DavidBuchanan314
force-pushed
the
token-revocation
branch
from
43a5c8e to
e4c5100
Compare
|
Actually, refreshsession should probably not revoke access tokens (just the old refresh token). access tokens don't really need jti at all. Edit: having jti in access tokens is useful for implementing deleteSession |
DavidBuchanan314
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.