Upgrade NPM packages, use Browserify directly #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes `gulp-browserify`. - Tested on Node v0.10, v4.0, v5.0
|
Should probably resolve #18. |
|
it fixed npm install errors for me. thanks! |
|
Thx bro |
|
thanks it fixed npm install error for me too |
|
Hello, @DavidWells - any chance of merging this? |
|
@gcpantazis - I actually have noticed another deprecation, all instances of |
|
As on current master, 'browserify' is not required. https://github.com/DavidWells/isomorphic-react-example/blob/master/package.json#l16 |
|
Hey all, I'm closing this since this project seems dead / I'd like to clean up my PR dashboard. If anyone else would like to own the PR / handle getting it merged with @DavidWells please feel free to cherrypick my patch! 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gulp-browserify.Hi there! I was having trouble checking this out due to some old dependencies (
browserifydepending onesprima-six, which no longer exists, specifically). So I upgraded them!gulp-browserifyis abandoned, so I just usedbrowserify.bundle()directly.The output is rendering, but I can't compare it to the previous version so I'll defer to you on whether or not it's correct. :) Thanks for the example!