-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Auroral Cypress Forest #166
Draft
Hugman76
wants to merge
32
commits into
dev
Choose a base branch
from
dusk
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,889
−305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/fr/hugman/promenade/Promenade.java # src/main/java/fr/hugman/promenade/PromenadeClient.java # src/main/java/fr/hugman/promenade/PromenadeFactory.java # src/main/java/fr/hugman/promenade/registry/content/CommonContent.java # src/main/java/fr/hugman/promenade/registry/content/MapleContent.java # src/main/java/fr/hugman/promenade/state/property/PromenadeBlockProperties.java # src/main/resources/assets/promenade/lang/en_us.json # src/main/resources/data/minecraft/tags/blocks/ceiling_hanging_signs.json # src/main/resources/data/minecraft/tags/blocks/fence_gates.json # src/main/resources/data/minecraft/tags/blocks/flower_pots.json # src/main/resources/data/minecraft/tags/blocks/logs_that_burn.json # src/main/resources/data/minecraft/tags/blocks/planks.json # src/main/resources/data/minecraft/tags/blocks/saplings.json # src/main/resources/data/minecraft/tags/blocks/standing_signs.json # src/main/resources/data/minecraft/tags/blocks/wall_hanging_signs.json # src/main/resources/data/minecraft/tags/blocks/wall_post_override.json # src/main/resources/data/minecraft/tags/blocks/wall_signs.json # src/main/resources/data/minecraft/tags/blocks/wooden_buttons.json # src/main/resources/data/minecraft/tags/blocks/wooden_doors.json # src/main/resources/data/minecraft/tags/blocks/wooden_fences.json # src/main/resources/data/minecraft/tags/blocks/wooden_pressure_plates.json # src/main/resources/data/minecraft/tags/blocks/wooden_slabs.json # src/main/resources/data/minecraft/tags/blocks/wooden_stairs.json # src/main/resources/data/minecraft/tags/blocks/wooden_trapdoors.json # src/main/resources/data/minecraft/tags/items/boats.json # src/main/resources/data/minecraft/tags/items/chest_boats.json # src/main/resources/data/minecraft/tags/items/hanging_signs.json # src/main/resources/data/minecraft/tags/items/leaves.json # src/main/resources/data/minecraft/tags/items/logs_that_burn.json # src/main/resources/data/minecraft/tags/items/planks.json # src/main/resources/data/minecraft/tags/items/saplings.json # src/main/resources/data/minecraft/tags/items/signs.json # src/main/resources/data/minecraft/tags/items/wooden_buttons.json # src/main/resources/data/minecraft/tags/items/wooden_doors.json # src/main/resources/data/minecraft/tags/items/wooden_fences.json # src/main/resources/data/minecraft/tags/items/wooden_pressure_plates.json # src/main/resources/data/minecraft/tags/items/wooden_slabs.json # src/main/resources/data/minecraft/tags/items/wooden_stairs.json # src/main/resources/data/minecraft/tags/items/wooden_trapdoors.json # src/main/resources/data/minecraft/tags/worldgen/biome/is_forest.json # src/main/resources/data/minecraft/tags/worldgen/biome/is_overworld.json # src/main/resources/data/minecraft/tags/worldgen/biome/stronghold_biased_to.json # src/main/resources/data/promenade/tags/blocks/leaf_piles.json # src/main/resources/data/promenade/tags/blocks/leaves.json
# Conflicts: # src/main/java/fr/hugman/promenade/Promenade.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concepts
The dusk cypress forest is a much more fantastical environment than what's usually seen in Mubble. In fact, it is the very first biome to feature fictitious foliage and wood. The dusk cypress forest is centered around the two themes of night and water:
At night, dusk cypress trees are adorned with star sparkles and might even emit light. The foliage also reminds of the sumptuous colors of aurora borealis or twiglight skies.
As for water, bubbles are omniscient as they're spurted out all around the place by new plants. The biome also features more frequent water lakes.
Features
Trees
Dusk Cypress trees are made out of a white log, with a black bark. Their foliage is made of a soothing turquoise to magenta gradient. They're taller than other trees but their foliage is narrow. They effectively look like real world cypress, from the conifers group.
Woodset
The dusk cypress feature a white woodset, that follows the design of generic Minecraft woodsets, except for the fences.
The dusk cypress fences look sturdier than other fences as they're made out of pickets (~4 per block?).
Leaves
The color of the leaves are defined by a 1/10 Perlin Noise mapped to a gradient (which we name dusk gradient) on the client.
At night, they are adorned with star sparkles. They may collectible - and a new star item will be added in this update - but this PR won't tackle it.
Forest
The forest biome spawns in place of Minecraft's forests. The grass color is turquoise, and must be greener than the tree foliage
Tasks
Marked features are added in the java code, and can be placed in the world. This does not mean that they have their resources and data ready (see below). Their functionality however, must be finished to be marked as complete.
Technicals
Resource Pack:
Data Pack:
Above and beyond
Here are some additional ideas that may not be included in this PR specifically.