fix release tags not recognized when not on a branch #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"dh-make-golang" creates the "debianized" source repo from scratch. It creates an empty git repo, adds the upstream as a remote, and fetches the tags. However, before this patch, it is using "git fetch" with no additional flags or options. This results in upstream tags not on any branches not being picked up. This patch adds "--tags" flag to "git fetch" so that it can fetch all upstream tags. Signed-off-by: William Lyu <[email protected]>
|
This merge request fixes #228 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"dh-make-golang" creates the "debianized" source repo from scratch. It creates an empty git repo, adds the upstream as a remote, and fetches the tags. However, before this patch, it is using "git fetch" with no additional flags or options. This results in upstream tags not on any branches not being picked up. This patch adds "--tags" flag to "git fetch" so that it can fetch all upstream tags.