Convert Project to Multi Module #11
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,285 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>com.deciphernow</groupId> | ||
| <artifactId>gm-data-sdk</artifactId> | ||
| <version>0.1.0-SNAPSHOT</version> | ||
| <name>${project.groupId}:${project.artifactId}</name> | ||
| <description>Grey Matter Data SDK</description> | ||
| <packaging>jar</packaging> | ||
| <scm> | ||
| <connection>scm:git:[email protected]:deciphernow/gm-gm-java-sdk.git</connection> | ||
| <developerConnection>scm:git:[email protected]:deciphernow/gm-java-sdk.git</developerConnection> | ||
| <url>https://github.com/deciphernow/gm-java-sdk</url> | ||
| </scm> | ||
| <distributionManagement> | ||
| <snapshotRepository> | ||
| <id>ossrh</id> | ||
| <url>https://oss.sonatype.org/content/repositories/snapshots</url> | ||
| </snapshotRepository> | ||
| <repository> | ||
| <id>ossrh</id> | ||
| <url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url> | ||
| </repository> | ||
| </distributionManagement> | ||
| <developers> | ||
| <developer> | ||
| <name>Parth Shah</name> | ||
| <organization>Decipher Technology Studios</organization> | ||
| <email>[email protected]</email> | ||
| </developer> | ||
| </developers> | ||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <jre.version>1.8</jre.version> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <commons.lang3.version>3.9</commons.lang3.version> | ||
| <commons.io.version>2.5</commons.io.version> | ||
| <commons.logging.version>1.2</commons.logging.version> | ||
| <gson.version>2.8.5</gson.version> | ||
| <guava.version>28.0-jre</guava.version> | ||
| <http.components.version>4.5.9</http.components.version> | ||
| <http.core.version>4.4.11</http.core.version> | ||
| <bouncycastle.plugin.version>1.0.0</bouncycastle.plugin.version> | ||
| <javadoc.plugin.version>3.1.0</javadoc.plugin.version> | ||
| <source.plugin.version>3.1.0</source.plugin.version> | ||
| <version.plugin.plugin>3.6.0</version.plugin.plugin> | ||
| <maven.clean.plugin.version>3.1.0</maven.clean.plugin.version> | ||
| <maven.resource.plugin.version>3.1.0</maven.resource.plugin.version> | ||
| <maven.surefire.plugin.version>2.22.2</maven.surefire.plugin.version> | ||
| <maven.dependency.plugin.version>3.1.1</maven.dependency.plugin.version> | ||
| <maven.compiler.plugin.version>3.8.1</maven.compiler.plugin.version> | ||
| </properties> | ||
| <repositories> | ||
| <repository> | ||
| <id>Sonatype</id> | ||
| <name>Sonatype RSO</name> | ||
| <layout>default</layout> | ||
| <url>http://repository.sonatype.org/</url> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| </snapshots> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| </repository> | ||
| <repository> | ||
| <id>Maven-Central</id> | ||
| <name>Maven Central</name> | ||
| <layout>default</layout> | ||
| <url>http://central.maven.org/maven2/</url> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| </snapshots> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| </repository> | ||
| <repository> | ||
| <id>Twitter-Maven</id> | ||
| <name>Twitter Maven</name> | ||
| <layout>default</layout> | ||
| <url>http://maven.twttr.com</url> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| </snapshots> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| </releases> | ||
| </repository> | ||
| </repositories> | ||
| <dependencies> | ||
| <!-- Commons Libraries --> | ||
| <dependency> | ||
| <groupId>commons-logging</groupId> | ||
| <artifactId>commons-logging</artifactId> | ||
| <version>${commons.logging.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| <version>${commons.lang3.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> | ||
| <version>${gson.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <!-- Apache HttpClient --> | ||
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpcore</artifactId> | ||
| <version>${http.core.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| <version>${http.components.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpmime</artifactId> | ||
| <version>${http.components.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <!-- Testing Libraries --> | ||
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>4.12</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <!-- For Build --> | ||
| <dependency> | ||
| <groupId>commons-io</groupId> | ||
| <artifactId>commons-io</artifactId> | ||
| <version>${commons.io.version}</version> | ||
| <scope>compile</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>${maven.surefire.plugin.version}</version> | ||
| <configuration> | ||
| <skipTests>true</skipTests> | ||
| <argLine>-Djavax.net.debug=all</argLine> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-plugin-plugin</artifactId> | ||
| <version>${version.plugin.plugin}</version> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-clean-plugin</artifactId> | ||
| <version>${maven.clean.plugin.version}</version> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-dependency-plugin</artifactId> | ||
| <version>${maven.dependency.plugin.version}</version> | ||
| <executions> | ||
| <execution> | ||
| <id>analyze</id> | ||
| <goals> | ||
| <goal>analyze-only</goal> | ||
| </goals> | ||
| <configuration> | ||
| <failOnWarning>true</failOnWarning> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>${maven.compiler.plugin.version}</version> | ||
| <configuration> | ||
| <source>${jre.version}</source> | ||
| <target>${jre.version}</target> | ||
| <encoding>UTF-8</encoding> | ||
| <forceJavacCompilerUse>true</forceJavacCompilerUse> | ||
| </configuration> | ||
| </plugin> | ||
|
There was a problem hiding this comment. Is this commented out because it's optional? |
||
| <!-- <plugin>--> | ||
| <!-- <groupId>org.apache.maven.plugins</groupId>--> | ||
| <!-- <artifactId>maven-javadoc-plugin</artifactId>--> | ||
| <!-- <version>${javadoc.plugin.version}</version>--> | ||
| <!-- <executions>--> | ||
| <!-- <execution>--> | ||
| <!-- <id>attach-javadocs</id>--> | ||
| <!-- <goals>--> | ||
| <!-- <goal>jar</goal>--> | ||
| <!-- </goals>--> | ||
| <!-- </execution>--> | ||
| <!-- </executions>--> | ||
| <!-- <configuration>--> | ||
| <!-- <skip>true</skip>--> | ||
| <!-- <excludePackageNames>*.transform</excludePackageNames>--> | ||
| <!-- <minmemory>128m</minmemory>--> | ||
| <!-- <maxmemory>1024m</maxmemory>--> | ||
| <!-- </configuration>--> | ||
| <!-- </plugin>--> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-resources-plugin</artifactId> | ||
| <version>${maven.resource.plugin.version}</version> | ||
| <configuration> | ||
| <encoding>UTF-8</encoding> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| <profiles> | ||
| <profile> | ||
| <id>deploy</id> | ||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>com.deciphernow</groupId> | ||
| <artifactId>bouncycastle-maven-plugin</artifactId> | ||
| <version>${bouncycastle.plugin.version}</version> | ||
| <configuration> | ||
| <passphrase>${env.PGP_PASSPHRASE}</passphrase> | ||
| <rings>${env.PGP_RINGS}</rings> | ||
| <userId>${env.PGP_USER_ID}</userId> | ||
| </configuration> | ||
| <executions> | ||
| <execution> | ||
| <id>sign-artifacts</id> | ||
| <phase>verify</phase> | ||
| <goals> | ||
| <goal>sign</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
|
There was a problem hiding this comment. I recommend adding a comment/justification for commented out blocks. I prefer just removing them. |
||
| <!-- <plugin>--> | ||
| <!-- <groupId>org.apache.maven.plugins</groupId>--> | ||
| <!-- <artifactId>maven-javadoc-plugin</artifactId>--> | ||
| <!-- <version>${javadoc.plugin.version}</version>--> | ||
| <!-- <executions>--> | ||
| <!-- <execution>--> | ||
| <!-- <id>attach-javadocs</id>--> | ||
| <!-- <phase>package</phase>--> | ||
| <!-- <goals>--> | ||
| <!-- <goal>jar</goal>--> | ||
| <!-- </goals>--> | ||
| <!-- </execution>--> | ||
| <!-- </executions>--> | ||
| <!-- </plugin>--> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-source-plugin</artifactId> | ||
| <version>${source.plugin.version}</version> | ||
| <executions> | ||
| <execution> | ||
| <id>attach-sources</id> | ||
| <phase>package</phase> | ||
| <goals> | ||
| <goal>jar</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </profile> | ||
| </profiles> | ||
| </project> | ||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that provided scope dependencies will need to be explicitly added by programs using this library. Is this really what we want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right...
compiledis probably what we need to resolve the transitive dependencies.