Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import History: Make the absence of action more clear #11637

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Maffooch
Copy link
Contributor

In the event an empty report is submitted, and there are no findings to be closed, the test_import_finding_action_set will be empty. When viewing import history objects, there is no indication as to what occurred.

image

[sc-9738]

@github-actions github-actions bot added the ui label Jan 24, 2025
Copy link

DryRun Security Summary

The pull request involves a minor enhancement to the view_test.html template, adding an empty block to the finding_action_list loop to display a message when no findings are created, closed, or modified during import, without introducing any security concerns.

Expand for full summary

Summary:

The code changes in this pull request appear to be a minor enhancement to the existing functionality of the view_test.html template in the dojo application. The changes include adding an empty block to the finding_action_list loop in the import history section, which will display a message if there were no findings created, closed, or modified during the import. From an application security perspective, this change does not introduce any obvious security concerns, as it seems to be focused on improving the user experience by providing more informative messages to the user. Overall, this change does not raise any immediate security red flags.

Files Changed:

  • dojo/templates/dojo/view_test.html: The changes in this file add an empty block to the finding_action_list loop in the import history section. This will display a message to the user if there were no findings created, closed, or modified during the import. This change is a minor enhancement to the existing functionality and does not introduce any apparent security vulnerabilities.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit c66e86b into DefectDojo:dev Jan 29, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants