fix(exit in bash): Fix handling exit everywhere #11650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiblik
force-pushed
the
init_bash_exit
branch
3 times, most recently
from
087756d to
5b5601e
Compare
kiblik
force-pushed
the
init_bash_exit
branch
from
5b5601e to
5560c43
Compare
kiblik
changed the title
kiblik
force-pushed
the
init_bash_exit
branch
from
5560c43 to
b9fa253
Compare
Yes, @Maffooch, #11651 covers also changes in this PR. However, implemented changes also make sense without other lines of code in #11651. As I wasn't sure if there would be any doubts or requests for changes in #11651, I decided to open this PR as well. If both of them will be accepted at the same time. This might be closed, and #11651 might be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #10493
The original exit (e.g. from #9002) worked correctly in sh.
However, by adding shellcheck, #9147 changed sh to bash which handles these situations differently.
Linter introduced an error that nobody noticed.
Issue discovered during investigation of #10490
|| truewithgrep?EXIT STATUS The grep utility exits with one of the following values: 0 One or more lines were selected. 1 No lines were selected. >1 An error occurred.grep's man page:So if there was not admin before, the checker would stop the whole process. Now there is not difference in output (if admin exists) and if there is no admin, the initializer just continues.
|| truewithls? Same answer.--set initializer.keepSeconds="x"? For easier troubleshooting (to keep the job in the stack when it is finished - do not remove it).