Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: erc20 gas format #140

Merged
merged 1 commit into from
Aug 20, 2024
Merged

🐛 fix: erc20 gas format #140

merged 1 commit into from
Aug 20, 2024

Conversation

rustin01
Copy link
Contributor

@rustin01 rustin01 commented Aug 20, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a callback prop onBeforeBack in the PageHeader component to allow custom behavior before back navigation.
    • Enhanced the SendTokenPage to reset token state before navigating back.
    • Improved gas cost estimation in the EthereumChainWallet class to return values directly in ether.
  • Bug Fixes

    • Adjusted gas cost calculation to use the correct format, improving accuracy in transactions.

Copy link
Contributor

coderabbitai bot commented Aug 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes enhance the functionality of the wallet application by introducing an onBeforeBack prop to the PageHeader component, enabling custom behavior before navigating back. Additionally, the EthereumChainWallet class updates the gas estimation method, ensuring gas costs are accurately represented in ether. These modifications improve user experience and align with best practices in state management and transaction handling.

Changes

Files Change Summary
apps/wallet/src/components/PageHeader.tsx Added onBeforeBack prop for custom logic before back navigation.
apps/wallet/src/pages/send-token/index.tsx Updated PageHeader to call sendTokenStore.reset() using the new onBeforeBack functionality.
apps/wallet/src/utils/chain/chain-wallets/ethereum/index.ts Modified gas estimation method to return values in ether, using formatEther instead of parseEther.

Poem

🐇 In the wallet’s heart, changes gleam,
A back button dance, a custom dream.
Gas costs now flow in ether’s light,
With every click, the future feels bright!
Hops of joy for these updates we see,
As we navigate smoothly, just like a breeze! 🌟


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustin01 rustin01 merged commit 04231dc into main Aug 20, 2024
2 checks passed
@rustin01 rustin01 deleted the fix/gas-calc branch August 20, 2024 08:43
Copy link

Deploy preview for hibit-id ready!

✅ Preview
https://hibit-onn74c9jp-delandlabs-projects.vercel.app

Built with commit 0507dab.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant