Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: support mainnet ICP and DOD token #171

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

rustin01
Copy link
Contributor

@rustin01 rustin01 commented Oct 19, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced asset list now includes temporary assets for "ICP" and "DOD" with detailed properties.
    • Added RPC endpoint for the Dfinity chain to improve network interaction.
    • Improved handling of ICRC1 asset balances and transfers with dynamic decimal retrieval.
  • Bug Fixes

    • Updated methods in the DfinityChainWallet class for better accuracy in managing ICRC assets.
  • Chores

    • Removed Dfinity from the list of supported chains for the testnet environment.

Copy link
Contributor

coderabbitai bot commented Oct 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve significant updates to the asset management and chain configuration within the wallet application. The useAllAssetListQuery function now returns an enhanced asset list that includes additional temporary assets for "ICP" and "DOD". The Dfinity chain configuration has been updated to include a specific RPC URL, and the DfinityChainWallet class has been modified to dynamically handle asset balances and transfers with improved decimal precision. Additionally, the Dfinity entry has been removed from the testnet supported chains.

Changes

File Path Change Summary
apps/wallet/src/apis/react-query/token.ts Updated useAllAssetListQuery to return a new array with additional temporary assets for "ICP" and "DOD". Updated import statement to include new types.
apps/wallet/src/utils/chain/chain-list.ts Added ['https://ic0.app'] to the rpcUrls array for the Dfinity chain configuration.
apps/wallet/src/utils/chain/chain-wallets/dfinity/index.ts Enhanced DfinityChainWallet class to dynamically retrieve decimal places for ICRC1 assets. Updated initWallet method to use the first RPC URL from this.chainInfo.rpcUrls[0]. Added getIcrcDecimals method.
apps/wallet/src/utils/chain/index.ts Removed Dfinity entry from the SupportedChainsForTestnet array.

Poem

In the wallet's realm, new assets bloom,
Temporary treasures dispel the gloom.
Dfinity's path now clearer to see,
With RPCs guiding, as swift as can be.
Balances dance with precision so bright,
In the world of chains, all feels just right! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustin01 rustin01 merged commit dd43c7f into main Oct 19, 2024
2 checks passed
@rustin01 rustin01 deleted the feat/mainnet-ICP&DOD branch October 19, 2024 08:12
Copy link

Deploy preview for hibit-id ready!

✅ Preview
https://hibit-fusb3g0dd-delandlabs-projects.vercel.app

Built with commit 7dd119e.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant