Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: improve send confirm page refresh and token list loading #209

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

rustin01
Copy link
Contributor

@rustin01 rustin01 commented Dec 9, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced routing logic for token sending, now requiring a specific address or symbol.
    • Added a loading spinner to the token list for improved user feedback during data fetching.
    • Improved navigation to the confirmation page with dynamic routing based on the token being sent.
  • Bug Fixes

    • Implemented a reset functionality for state management after token transactions to prevent residual state issues.
  • Improvements

    • Updated the SendButton component to visually indicate when it is disabled based on token availability.

@rustin01 rustin01 merged commit 37ac1c3 into main Dec 9, 2024
1 check passed
Copy link
Contributor

coderabbitai bot commented Dec 9, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications across multiple components in the wallet application, primarily focusing on enhancing routing logic, state management, and user experience. Key changes include making the addressOrSymbol parameter required in token sending routes, improving the visual feedback of the SendButton component, adding a loading spinner in the TokenList, and implementing a reset functionality for the sendTokenStore state. Additionally, the navigation logic in the SendTokenPage has been adjusted to dynamically reflect the token or address being sent.

Changes

File Change Summary
apps/wallet/src/App.tsx Added import for sendTokenStore, updated token sending route to require addressOrSymbol, and modified confirmation page routing based on sendTokenStore.state.token.
apps/wallet/src/components/SendButton.tsx Updated button styling to include disabled:bg-primary and disabled:opacity-50, added disabled attribute based on token prop presence.
apps/wallet/src/components/TokenList.tsx Introduced a loading spinner for the token list while data is being fetched, conditional rendering based on assetsQuery.isPending.
apps/wallet/src/pages/main/index.tsx Modified defaultTokenQuery to include a check for ChainAssetType.ICP alongside the existing check for ChainAssetType.Native.
apps/wallet/src/pages/send-token/confirm-page.tsx Added reset functionality for sendTokenStore state after successful transactions and when the user closes the confirmation page.
apps/wallet/src/pages/send-token/index.tsx Updated navigation logic in handleSend to dynamically include addressOrSymbol in the confirmation route and modified useEffect to set the token state based on state.token or tokenQuery.

Possibly related PRs

  • feat: sign test and chainassetType update #176: The changes in the DfinityChainWallet class update the handling of asset types to include ChainAssetType.ICP and ChainAssetType.ICRC3, which may relate to the routing logic in the main PR that involves token sending and confirmation, as both involve managing different asset types in the wallet.

🐇 In the wallet, we hop and play,
Sending tokens on their way.
With buttons bright and spinners spun,
Our journey's just begun!
So gather 'round, let's make a cheer,
For smoother sends and no more fear! 🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 202c104 and f06fdef.

📒 Files selected for processing (6)
  • apps/wallet/src/App.tsx (2 hunks)
  • apps/wallet/src/components/SendButton.tsx (1 hunks)
  • apps/wallet/src/components/TokenList.tsx (1 hunks)
  • apps/wallet/src/pages/main/index.tsx (1 hunks)
  • apps/wallet/src/pages/send-token/confirm-page.tsx (1 hunks)
  • apps/wallet/src/pages/send-token/index.tsx (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustin01 rustin01 deleted the feat/improve-loading-and-refresh branch December 9, 2024 02:29
Copy link

github-actions bot commented Dec 9, 2024

Deploy preview for hibit-id ready!

✅ Preview
https://hibit-iel7s3jsh-delandlabs-projects.vercel.app

Built with commit f06fdef.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant