Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: draggable sdk button #96

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

rustin01
Copy link
Contributor

@rustin01 rustin01 commented Aug 6, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced HibitIdController for improved drag-and-drop functionality, allowing more flexible user interactions.
    • Introduced a new updateStyle method in HibitIdIframe for dynamic style updates.
    • Added a utility function clamp to constrain values within specified bounds.
    • Implemented a handleControllerMove method in HibitIdWallet to ensure the iframe remains visible and well-positioned.
  • Bug Fixes

    • Adjusted iframe positioning logic to prevent it from going off-screen based on user interactions.

Copy link
Contributor

coderabbitai bot commented Aug 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes enhance the interactivity and usability of the HibitIdController and HibitIdIframe classes by adding flexible event handling and repositioning capabilities. New methods support drag-and-drop functionality, while a clamp utility function ensures element boundaries are respected. The HibitIdWallet class also adapts to these enhancements by dynamically adjusting iframe positioning based on user interactions, providing a more responsive and engaging user interface.

Changes

Files Change Summary
packages/sdk/src/lib/dom/index.ts, packages/sdk/src/lib/wallet.tsx Modified HibitIdController to accept additional interaction handlers, introduced new mouse event methods to support dragging, and improved iframe positioning logic in HibitIdWallet.
packages/sdk/src/lib/utils.ts Added a new utility function clamp to constrain values within specified bounds.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Controller
    participant Iframe

    User->>Controller: mouse down
    Controller->>Controller: setDraggingState(true)
    User->>Controller: mouse move
    Controller->>Controller: update position
    Controller->>Iframe: reposition
    User->>Controller: mouse up
    Controller->>Controller: check click time
    alt Quick Click
        Controller->>Controller: handleClick
        Controller->>Iframe: toggle visibility
    end
Loading

🐰 In the garden of code, changes bloom bright,
With clamping and clicking, our features take flight.
I hop through the updates, a curious sight,
Interactive joy makes the user delight!
Let's dance with the mouse, oh what a delight! 🌼✨


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustin01 rustin01 merged commit 037c31b into main Aug 6, 2024
2 checks passed
@rustin01 rustin01 deleted the feat/draggable-sdk-button branch August 6, 2024 10:17
Copy link

github-actions bot commented Aug 6, 2024

Deploy preview for hibit-id ready!

✅ Preview
https://hibit-piwacmdl6-delandlabs-projects.vercel.app

Built with commit 56122ff.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant