-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: draggable sdk button #96
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe recent changes enhance the interactivity and usability of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Controller
participant Iframe
User->>Controller: mouse down
Controller->>Controller: setDraggingState(true)
User->>Controller: mouse move
Controller->>Controller: update position
Controller->>Iframe: reposition
User->>Controller: mouse up
Controller->>Controller: check click time
alt Quick Click
Controller->>Controller: handleClick
Controller->>Iframe: toggle visibility
end
Note Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Deploy preview for hibit-id ready! ✅ Preview Built with commit 56122ff. |
Summary by CodeRabbit
New Features
HibitIdController
for improved drag-and-drop functionality, allowing more flexible user interactions.updateStyle
method inHibitIdIframe
for dynamic style updates.clamp
to constrain values within specified bounds.handleControllerMove
method inHibitIdWallet
to ensure the iframe remains visible and well-positioned.Bug Fixes