Deprecate typing-module type hints in favour of Python 3.10+ built-in type hints
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since support for Python 3.9 was dropped, all supported versions of Python now have native basic type hinting available. All references to `typing`'s Dict, List, Optional, Set, Type and Union have been replaced by the built-in Python equivalent (which borrows from `typing`).
Update type hinting and remove redundant imports from `typing`
Fix order errors and reformat
Default isort sorting and black formatting
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #221.
In summary, this PR replaces all typing-module type hints by supported built-in type hints. This replaces
List,Dict,Tuple,Type,UnionandOptionalwithlist,dict,tuple,type, Python's UnionX | Yoperand and Python's OptionalX | Noneoperand, respectively.