Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow pr-comment.yml pull-requests: write #701

Merged
merged 1 commit into from
Jun 16, 2024
Merged

allow pr-comment.yml pull-requests: write #701

merged 1 commit into from
Jun 16, 2024

Conversation

chris48s
Copy link
Member

No description provided.

Copy link

This PR has been deployed.

@chris48s
Copy link
Member Author

Right. This fixes your GitHub actions build
Tbh, I still think this is a bit busted. Really the PR comment should happen after the staging deploy has succeeded, not before but.. lets stop pulling the thread there for this evening.

Lets review/merge this one first. Then I'll rebase #699 and #700 on this so they run the tests and do a staging deploy for you.

From memory, I can't remember if workflows with pull-requests: write will work on PRs from forks. If not, I'll re-push them as local branches (as we can see form this PR I still have push access to this repo).

@chris48s chris48s merged commit cbf8da0 into master Jun 16, 2024
3 checks passed
@chris48s
Copy link
Member Author

Replaced #699 and #700 with #702 and #703 but they're good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants