Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match widget text to WDIV #708

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Match widget text to WDIV #708

merged 1 commit into from
Jun 28, 2024

Conversation

VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented Jun 25, 2024 •
edited
Loading

This change:

  • matches text to WDIV
  • adds Welsh translation for Voter ID requirements.

Screenshot 2024-06-26 at 10 28 01 AM

Screenshot 2024-06-26 at 10 31 44 AM

@github-actions GitHub Actions
Copy link

This PR has been deployed.

@VirginiaDooley VirginiaDooley requested a review from chris48s June 25, 2024 10:42
@VirginiaDooley VirginiaDooley requested review from symroe and removed request for chris48s and symroe June 25, 2024 10:42
@VirginiaDooley VirginiaDooley changed the title Translate voter ID requirements Match widget text to WDIV Jun 26, 2024
@VirginiaDooley VirginiaDooley requested a review from symroe June 26, 2024 09:33
@VirginiaDooley VirginiaDooley force-pushed the hotfix/voter-id-requirements-welsh branch from 567f9a2 to 5909516 Compare June 26, 2024 09:35
symroe
symroe reviewed Jun 27, 2024
View reviewed changes
src/translations/en.json Outdated
"cancelled.rescheduled.header":"Uncontested and Rescheduled Election"
"cancelled.rescheduled.header":"Uncontested and Rescheduled Election",
"voter_id_requirements.header": "Voter ID",
"voter_id_requirements.instructions": "YYou will need to take photo ID to vote at a polling station in this election. You do not need your poll card to vote. You must vote at your assigned polling station. ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YYYYYYY

@VirginiaDooley VirginiaDooley force-pushed the hotfix/voter-id-requirements-welsh branch from 5909516 to 496de4f Compare June 28, 2024 07:33
@VirginiaDooley VirginiaDooley requested a review from symroe June 28, 2024 07:34
@VirginiaDooley VirginiaDooley merged commit 8204470 into master Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symroe symroe symroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VirginiaDooley @symroe