Remove old models #301
Merged
Remove old models #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is step one in removing the party model. We currently have two ways of storing the party of a leaflet: 1. The (old) Party model that requires us syncing parties with a 3rd party data source 2. Pulling in the Party data from YNR when we look up a ballot as part of the uploader. New leaflets use method two, so this migration moves old data inline with new data. It's very possible we decide to denormalize this again in future, but for now I want to reduce complexity and move all data to the same system. I've verified with a prod export that there is no missing data using this method.
symroe
force-pushed
the
remove-old-models
branch
2 times, most recently
from
c6bba26 to
e3895de
Compare
symroe
force-pushed
the
remove-old-models
branch
from
e3895de to
f5558b9
Compare
|
I wanted to remove I think the best option might be to squash / reset all migrations in this project once this PR is merged, then we can remove the library. |
symroe
force-pushed
the
remove-old-models
branch
2 times, most recently
from
9b1485e to
0e4b972
Compare
|
I've tested this on a recent prod DB export and it's working fine, migrations applying in order and I can't see any data loss. I'll also take a snapshot of the prod DB before merging. |
This was referenced Dec 9, 2024
chris48s
reviewed
Dec 10, 2024
electionleaflets/apps/leaflets/migrations/0006_move_party_model_to_ynr_party.py
Show resolved
Hide resolved
electionleaflets/apps/leaflets/migrations/0006_move_party_model_to_ynr_party.py
Show resolved
Hide resolved
electionleaflets/apps/leaflets/migrations/0008_move_publisher_person_data_to_ynr_id.py
Outdated
Show resolved
Hide resolved
electionleaflets/apps/leaflets/migrations/0008_move_publisher_person_data_to_ynr_id.py
Outdated
Show resolved
Hide resolved
chris48s
reviewed
Dec 10, 2024
chris48s
approved these changes
Dec 11, 2024
Nothing in here is being used, the tables aren't in the prod database, and there're not managed, so there's no migrations to write
We're not writing to this model any more, and even if we were it's not clear that it's useful: it's the 2010 boundaries with no ability to version them. We also might not want to filter by constituency anyway. As we have the postcode for every leaflet, we can re-make this in a way that we think is useful, at some point later.
Fixes #273 None of these models did anything
symroe
force-pushed
the
remove-old-models
branch
from
ec882e9 to
6261920
Compare
This was referenced Dec 11, 2024
Remove
Party model and related uk_political_parties project, migrate data to on-leaflet fields.
#276
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right, this PR is doing a fair amount, but I thought doing it in one would be about as easy to review as doing a whole load. Plus, the ordering matters, as you need to remove FKs from models before we delete them, and I didn't want to keep track of the migration history as we merged them.
At a high level, the pattern here is to collapse the schema down to everything being on the
Leaflet. This is how we've been writing data for the last few years, so really we're just normalizing to a single schema rather than trying to work with more than one at a time.We need to talk about the future shape of schema, but for now I think collapsing down is easier, and removes a whole load of unused code.
I've also made some other quality of life code changes and tidied up from some previous commits
This PR deals with the following issues:
Partymodel and relateduk_political_partiesproject, migrate data to on-leaflet fields. #276 (partly, see comment)Constituencymodel and related code #269Countrymodel and related code, replace with NUTS1 codes #273Plus some more drive-by improvements that didn't have issues.