MAG/SHD Fixes (#466)

* [MAG-All] Corrected element use for low level rotation. * [SHD-Laz] Added a check for a popular outside buff to Call Attack buffs to correct improper stacking information supplied to the script.
DerpleMQ2 · Feb 14, 2025 · 04cf612 · 04cf612
1 parent 81f635b
commit 04cf612
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/class_configs/Live/mag_class_config.lua b/class_configs/Live/mag_class_config.lua
@@ -1598,6 +1598,7 @@ _ClassConfig      = {
                 name = "BigFireDD",
                 type = "Spell",
                 cond = function(self, spell, target)
+                    if Config:GetSetting('ElementChoice') ~= 1 then return false end
                     if (Targeting.GetTargetPctHPs(target) < Config:GetSetting('HPStopBigNuke') and not Targeting.IsNamed(target)) then return false end
                     return (Casting.HaveManaToNuke() or Casting.BurnCheck()) and Casting.TargetedSpellReady(spell, target.ID())
                 end,
@@ -1606,13 +1607,15 @@ _ClassConfig      = {
                 name = "FireDD",
                 type = "Spell",
                 cond = function(self, spell, target)
+                    if Config:GetSetting('ElementChoice') ~= 1 then return false end
                     return (Casting.HaveManaToNuke() or Casting.BurnCheck()) and Casting.TargetedSpellReady(spell, target.ID())
                 end,
             },
             {
                 name = "MagicDD",
                 type = "Spell",
                 cond = function(self, spell, target)
+                    if Config:GetSetting('ElementChoice') ~= 2 then return false end
                     return (Casting.HaveManaToNuke() or Casting.BurnCheck()) and Casting.TargetedSpellReady(spell, target.ID())
                 end,
             },

diff --git a/class_configs/Project Lazarus/mag_class_config.lua b/class_configs/Project Lazarus/mag_class_config.lua
@@ -1623,6 +1623,7 @@ _ClassConfig      = {
                 name = "BigFireDD",
                 type = "Spell",
                 cond = function(self, spell, target)
+                    if Config:GetSetting('ElementChoice') ~= 1 then return false end
                     if (Targeting.GetTargetPctHPs(target) < Config:GetSetting('HPStopBigNuke') and not Targeting.IsNamed(target)) then return false end
                     return (Casting.HaveManaToNuke() or Casting.BurnCheck()) and Casting.TargetedSpellReady(spell, target.ID())
                 end,
@@ -1631,13 +1632,15 @@ _ClassConfig      = {
                 name = "FireDD",
                 type = "Spell",
                 cond = function(self, spell, target)
+                    if Config:GetSetting('ElementChoice') ~= 1 then return false end
                     return (Casting.HaveManaToNuke() or Casting.BurnCheck()) and Casting.TargetedSpellReady(spell, target.ID())
                 end,
             },
             {
                 name = "MagicDD",
                 type = "Spell",
                 cond = function(self, spell, target)
+                    if Config:GetSetting('ElementChoice') ~= 2 then return false end
                     return (Casting.HaveManaToNuke() or Casting.BurnCheck()) and Casting.TargetedSpellReady(spell, target.ID())
                 end,
             },

diff --git a/class_configs/Project Lazarus/shd_class_config.lua b/class_configs/Project Lazarus/shd_class_config.lua
@@ -926,7 +926,8 @@ local _ClassConfig = {
                 tooltip = Tooltips.CallAtk,
                 active_cond = function(self, spell) return Casting.BuffActiveByID(spell.RankName.ID()) end,
                 cond = function(self, spell)
-                    return self.ClassConfig.HelperFunctions.SingleBuffCheck() and Casting.SelfBuffCheck(spell)
+                    return self.ClassConfig.HelperFunctions.SingleBuffCheck() and Casting.SelfBuffCheck(spell) and
+                        not mq.TLO.Me.Buff("Howl of the Predator")() --fix for bad stacking check
                 end,
             },
             --You'll notice my use of TotalSeconds, this is to keep as close to 100% uptime as possible on these buffs, rebuffing early to decrease the chance of them falling off in combat