enable CI for building #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpalmvik
reviewed
Apr 16, 2024
.github/workflows/build.yml
Outdated
| runs-on: ${{ matrix.os }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
I would suggest using the modern checkout@v4 based on a supported Node version, instead of the legacy v3.
That is unless there is a particular reason that I’m missing completely 🤗
There was a problem hiding this comment.
Oh, no reason at all, just copied what I had around in some other project 🙂. I'll change it to v4
There was a problem hiding this comment.
Done, and build is now green after rebasing, also fixed artifacts https://github.com/Arcnor/Descent3/actions/runs/8712259559
Arcnor
force-pushed
the
main
branch
2 times, most recently
from
44cde05 to
765883f
Compare
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple CI config, could be used to maybe check that #13 builds properly before merging.
That said, AngelScript fails to build as mentioned in #10 (although for some strange reason I cannot reproduce it locally!) so the build is red, but still only a single failure should be expected for that PR.It's easy to remove from the CMakeLists though, but I didn't want to generate conflicts with that PR just in case.Update: Build is green after rebasing: https://github.com/Arcnor/Descent3/actions/runs/8712259559