ASAN/UBSAN fixes #582
Merged
ASAN/UBSAN fixes #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sndlib/mixer.cpp:496:61: runtime error: left shift of negative value -1 sndlib/mixer.cpp:333:74: runtime error: left shift of negative value -1 sndlib/mixer.cpp:331:115: runtime error: left shift of negative value -2 x<<y is UB for y<0 or x<0. Using a multiply side-steps this (and compilers optimize multiplies to the same ASM anyway).
winterheart
reviewed
Sep 12, 2024
$GIT/lib/grdefs.h:85:67: runtime error: left shift of negative value -1 $GIT/lib/grdefs.h:85:79: runtime error: left shift of negative value -1 This happens because of: grtext/grtext.cpp:966 966 col = GR_RGB(str[i + 1], str[i + 2], str[i + 3]); (gdb) p str $2 = 0x46437fe <Grtext_buffer+62> "\001\377\377\377Max. Trans-Atmospheric" (gdb) ptyp str type = char * Make GR_RGB take uint8_ts, which causes the desired conversion at GR_RGB callsites.
Descent3/aipath.cpp:663:40: runtime error: index -1 out of bounds for type 'short unsigned int [5]' Fixes: bb1d6f6
|
Tested on Linux, no issues found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
lesser UBSAN fixes
Checklist