[#130] Fix: Fetch inner Join으로 인한 404 에러 문제 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunSang1121
approved these changes
Jun 4, 2024
JunSang1121
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
🎋 Branch Name
fix/#130
🔑 Main Contents
참여중인 방 여부 검사 API에서 활용된 Fetch Join 메소드를 수정하였습니다.
-> User가 존재할때 하위의 userRoomList가 비어있더라도 정상 반환되도록, (inner) JOIN 대신 LEFT (outer) JOIN 으로 수정.
🏞 Screenshots (Optional)
📋 Checks for reviewers (Optional)
위의 스크린샷에서 보시다시피, 성공 테스트도 완료하였습니다.