[#144] Refactor: Dto Inner Class 리펙토링 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkguswls1106
requested changes
Jun 11, 2024
| public static class SolvePageResponse { | ||
|
|
||
| // Problem | ||
| private ProblemDto.Response problemDto; |
There was a problem hiding this comment.
DTO 변수 네이밍 컨벤션 문제 : problemDto -> problemResponseDto 수정 부탁드립니다.
| private String code; | ||
|
|
||
| public SolvePageResponse(UserRoom entity, List<UserDto.Response> rankUserDtoList) { | ||
| this.problemDto = new ProblemDto.Response(entity.getRoom().getProblem()); |
There was a problem hiding this comment.
DTO 변수 네이밍 컨벤션 문제 : problemDto -> problemResponseDto 수정 부탁드립니다.
| public ResponseEntity<ResponseData<TokenDto>> reissue(@RequestBody ReissueRequestDto reissueRequestDto) { | ||
| TokenDto tokenDto = authService.reissue(reissueRequestDto); | ||
| public ResponseEntity<ResponseData<AuthDto.TokenResponse>> reissue(@RequestBody AuthDto.ReissueRequest reissueRequestDto) { | ||
| AuthDto.TokenResponse tokenDto = authService.reissue(reissueRequestDto); |
There was a problem hiding this comment.
네이밍 컨벤션상, tokenDto -> tokenResponseDto가 옳습니다.
| public ResponseEntity<ResponseData<TokenDto>> reissue(@RequestBody ReissueRequestDto reissueRequestDto) { | ||
| TokenDto tokenDto = authService.reissue(reissueRequestDto); | ||
| public ResponseEntity<ResponseData<AuthDto.TokenResponse>> reissue(@RequestBody AuthDto.ReissueRequest reissueRequestDto) { | ||
| AuthDto.TokenResponse tokenDto = authService.reissue(reissueRequestDto); | ||
| return ResponseData.toResponseEntity(ResponseCode.REISSUE_SUCCESS, tokenDto); |
| @@ -37,7 +37,7 @@ public void onAuthenticationSuccess(HttpServletRequest request, HttpServletRespo | |||
| Long userId = oAuth2User.getUserId(); | |||
| Role role = oAuth2User.getRole(); | |||
|
|
|||
| TokenDto tokenDto = tokenProvider.generateTokenDto(userId, role); // Access & Refresh 토큰 발행. | |||
| AuthDto.TokenResponse tokenDto = tokenProvider.generateTokenDto(userId, role); // Access & Refresh 토큰 발행. | |||
There was a problem hiding this comment.
DTO 변수 네이밍 컨벤션 문제 : tokenDto -> tokenResponseDto 수정 부탁드립니다.
| @@ -66,7 +66,7 @@ public void onAuthenticationSuccess(HttpServletRequest request, HttpServletRespo | |||
| } | |||
| } | |||
|
|
|||
| public String makeRedirectUrl(TokenDto tokenDto, String frontendPath) { | |||
| public String makeRedirectUrl(AuthDto.TokenResponse tokenDto, String frontendPath) { | |||
There was a problem hiding this comment.
DTO 변수 네이밍 컨벤션 문제 : tokenDto -> tokenResponseDto 수정 부탁드립니다.
| @@ -115,7 +112,7 @@ public TokenDto reissue(ReissueRequestDto reissueRequestDto) { // Refresh Token | |||
| throw new Exception400.TokenBadRequest("Refresh Token = " + refreshToken); | |||
| } | |||
|
|
|||
| TokenDto tokenDto = tokenProvider.generateAccessTokenByRefreshToken(userId, role, refreshToken); | |||
| AuthDto.TokenResponse tokenDto = tokenProvider.generateAccessTokenByRefreshToken(userId, role, refreshToken); | |||
There was a problem hiding this comment.
DTO 변수 네이밍 컨벤션 문제 : tokenDto -> tokenResponseDto 수정 부탁드립니다.
| @@ -115,7 +112,7 @@ public TokenDto reissue(ReissueRequestDto reissueRequestDto) { // Refresh Token | |||
| throw new Exception400.TokenBadRequest("Refresh Token = " + refreshToken); | |||
| } | |||
|
|
|||
| TokenDto tokenDto = tokenProvider.generateAccessTokenByRefreshToken(userId, role, refreshToken); | |||
| AuthDto.TokenResponse tokenDto = tokenProvider.generateAccessTokenByRefreshToken(userId, role, refreshToken); | |||
| return tokenDto; | |||
tkguswls1106
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
🎋 Branch Name
refactor/#144
🔑 Main Contents
해당 Dto의 Entity에 따라 Dto Class를 분류 후 사용처에 맞게 InnerClass작성
🏞 Screenshots (Optional)