Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#23] Feat: WebClient 외부 API 호출 메소드 작성 #24

Merged
merged 4 commits into from
May 16, 2024

Conversation

JunSang1121
Copy link
Collaborator

PULL REQUEST

🎋 Branch Name

feat/#23

🔑 Main Contents

WebClient 외부 API 호출 메소드 작성

@JunSang1121 JunSang1121 added the ✨ Feat 기능 구현 label May 16, 2024
@JunSang1121 JunSang1121 self-assigned this May 16, 2024
@JunSang1121 JunSang1121 linked an issue May 16, 2024 that may be closed by this pull request
2 tasks
@@ -0,0 +1,18 @@
package com.sajang.devracebackend.dto.solvedcount;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solvedcount 디렉토리명을 user로 수정해주세요.

public interface UserService {
SolvedResponseDto checkUserSolvedCount(String userid);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userid 카멜케이스로 네이밍 수정 부탁드리며, 변수명은 bojId가 옳은 선언입니다.

@@ -0,0 +1,18 @@
package com.sajang.devracebackend.dto.solvedcount;


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엔터여백 한줄 삭제 부탁드립니다.

@JunSang1121
Copy link
Collaborator Author

모두 수정했습니다. 재 요청하겠습니다.

Copy link
Member

@tkguswls1106 tkguswls1106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인합니다. 고생하셨습니다.

@JunSang1121 JunSang1121 merged commit 28b8f69 into develop May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feat 기능 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] WebClient 외부 API 호출 기능
2 participants