fix: exclude page complete in signup

DevKor-github · Jul 6, 2024 · 5a9282b · 5a9282b
1 parent 2b5597d
commit 5a9282b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/src/common/enums/page.enum.ts b/src/common/enums/page.enum.ts
@@ -15,5 +15,4 @@ export enum Page {
   hobby = 14,
   images = 15,
   job = 16,
-  complete = 17,
 }
diff --git a/src/domain/auth/auth.controller.ts b/src/domain/auth/auth.controller.ts
@@ -68,19 +68,6 @@ export class AuthController {
     @Body() info: SignupUserRequestDto,
   ) {
     const { id, infoId, page } = signupPayload;
-    if (page == 17) {
-      const result = await this.authService.checkComplete(id);
-      if (!result) throw new BadRequestException('invalid info');
-
-      const nickname = await this.userService.pickRandomNickname();
-      await this.userService.updateUser(id, 'userNickname', nickname);
-      await this.userService.createSocketUser(id);
-      return {
-        refreshToken: await this.authService.getRefreshToken(id),
-        accessToken: this.authService.getAccessToken(id),
-        userId: id,
-      };
-    }
 
     const pageName = Object.keys(Page).find((key) => Page[key] == page);
 
@@ -97,6 +84,20 @@ export class AuthController {
       case 'birth':
         await this.userService.updateUser(id, 'birth', info['birth']);
         break;
+      case 'job':
+        await this.userService.updateUserInfo(infoId, pageName, info[pageName]);
+
+        const result = await this.authService.checkComplete(id);
+        if (!result) throw new BadRequestException('invalid info');
+
+        const nickname = await this.userService.pickRandomNickname();
+        await this.userService.updateUser(id, 'userNickname', nickname);
+        await this.userService.createSocketUser(id);
+        return {
+          refreshToken: await this.authService.getRefreshToken(id),
+          accessToken: this.authService.getAccessToken(id),
+          userId: id,
+        };
       default:
         await this.userService.updateUserInfo(infoId, pageName, info[pageName]);
     }