Refactor/search course #121
Conversation
- category์ ๋ฐ๋ผ ์ ๊ณต, ๊ต์, ํ๋ฌธ์ ๊ธฐ์ด๊ฐ ๋๊ฒ
| required: true, | ||
| type: 'string', | ||
| type: 'enum', |
There was a problem hiding this comment.
| type: 'enum', | |
| type: 'enum', | |
| enum: CourseCategory, |
์๊ฑฐ ๋ฃ์ด์ฃผ๋ฉด swagger์์ ์์ฒญ์ด ์ ๊ฐ๋๊ฑฐ ๊ฐ์ต๋๋ค
| @ApiProperty({ description: '์ฐ๋' }) | ||
| @IsString() | ||
| @Length(4) | ||
| year: string; | ||
|
|
||
| @ApiProperty({ description: 'ํ๊ธฐ' }) | ||
| @IsString() | ||
| @Length(1) | ||
| semester: string; |
There was a problem hiding this comment.
| @ApiProperty({ description: '์ฐ๋' }) | |
| @IsString() | |
| @Length(4) | |
| year: string; | |
| @ApiProperty({ description: 'ํ๊ธฐ' }) | |
| @IsString() | |
| @Length(1) | |
| semester: string; | |
| @ApiProperty({ description: '์ฐ๋' }) | |
| @IsString() | |
| @Length(4, 4) | |
| year: string; | |
| @ApiProperty({ description: 'ํ๊ธฐ' }) | |
| @IsString() | |
| @Length(1, 1) | |
| semester: string; |
์ฌ์ํ์ง๋ง ์๋ฐ๊ฑฐ๋ผ๋...
src/course/course.service.ts
Outdated
| async getCourseRepository(): Promise<CourseRepository> { | ||
| return this.courseRepository; | ||
| } |
There was a problem hiding this comment.
์ ํจ์๋ ๋ฌด์จ์ญํ ์ธ์ง ๋ฌผ์ด๋ด๋ ๋ ๊น์..?
There was a problem hiding this comment.
์ง์ด๋ค๋๊ฑธ ๊น๋นกํ๋ค์...
| @Injectable() | ||
| export class AllCoursesSearchStrategy implements CourseSearchStrategy { | ||
| supports(category: CourseCategory): boolean { | ||
| return !category; |
There was a problem hiding this comment.
์ ๋ถ๋ถ์ ์๋๋ ๊ถ๊ธํฉ๋๋ค..!
There was a problem hiding this comment.
ํ๋ก ํธ์์ category๋ฅผ ์ง์ ํ์ง ์์ ๋ category๋ฅผ ์๋ฌด๊ฒ๋ ๋๊ฒจ์ฃผ์ง ์๋๋ฐ, ์ด๋ ํด๋น ์ ๋ต์ ์ฑํํ๋ ค๊ณ ๋ฃ์์ต๋๋ค!
| }), | ||
| ApiQuery({ | ||
| name: 'courseName', | ||
| name: 'category', | ||
| required: true, |
There was a problem hiding this comment.
์ ๊ทธ๋ผ ์๊ฑฐ false๊ฐ ๋๋๊ฒ ๋ง์๊ฑฐ ๊ฐ์์ฉ
- category๋ ์ ๋๊ฒจ์ค๋๋ ์์ด์ false๋ก ์์
| import { CourseEntity } from 'src/entities/course.entity'; | ||
|
|
||
| export interface CourseSearchStrategy { | ||
| supports(category: CourseCategory): boolean; |
There was a problem hiding this comment.
์ฌ์ํ๊ฑฐ์ง๋ง category ๋งค๊ฐ๋ณ์์ ?๋ฅผ ๋ถ์ด๊ฑฐ๋ ํ์
์ | undefined ๋ฅผ ์ถ๊ฐํด์ฃผ๋ฉด ์ข ๋ ์ฝ๋๋ฅผ ์ฝ๊ธฐ ์ข์๊ฑฐ ๊ฐ์์
์ง๊ธ๋ ์๋๋๋ก ๋์์ ์ ํ๋๊ฑฐ ๊ฐ์ต๋๋ค..!
|
|
||
| buildQuery( | ||
| queryBuilder: SelectQueryBuilder<CourseEntity>, | ||
| searchCourseNewDto?: SearchCourseNewDto, |
There was a problem hiding this comment.
์คํ๋ ค ์๊ธฐ ๋งค๊ฐ๋ณ์๋ ํญ์ ๋ค์ด๊ฐ๋๊ฑฐ ๊ฐ์์ ๋ง๋ค๋ฉด ? ๋นผ์ค๋ ์ข์๊ฑฐ ๊ฐ์์
๐ Description
๊ฐ์ ๊ฒ์ ์๋ํฌ์ธํธ๋ฅผ ํ๋๋ก ํตํฉํ์ต๋๋ค.
๐งช Test
๊ธฐ์กด ๊ฐ์ ๊ฒ์๊ณผ ๋์ผํ๊ฒ ๊ฒฐ๊ณผ๋ฅผ ๋ฐํํ๋์ง ํ์ธํด์ฃผ์๋ฉด ๊ฐ์ฌํ๊ฒ ์ต๋๋ค.
๐ธ ETC
R.I.P ์ํ and ์ฐ์น's past code...