Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump and pin swc again, pin more swc crates #67

Merged
merged 8 commits into from
Aug 29, 2024

Conversation

pyrrho
Copy link
Contributor

@pyrrho pyrrho commented Aug 28, 2024

This is an alternative to DioxusLabs/dioxus#2861 and should close DioxusLabs/dioxus#2878

@pyrrho
Copy link
Contributor Author

pyrrho commented Aug 28, 2024

I believe this will fix the install issue, but I'm not sure how to confirm that, because I can't seem to reproduce the failure when running cargo build -p dioxus-cli --release inside of a local clone of Dioxus checked out at the v0.6.0-alpha.2 tag. :-/

@ealmloff
Copy link
Member

I believe this will fix the install issue, but I'm not sure how to confirm that, because I can't seem to reproduce the failure when running cargo build -p dioxus-cli --release inside of a local clone of Dioxus checked out at the v0.6.0-alpha.2 tag. :-/

You need to run cargo update in the local repo to mimic the fact that cargo install ignores the lock file by default

@pyrrho
Copy link
Contributor Author

pyrrho commented Aug 28, 2024

cargo install ignores the lock file by default

Hence installing with --locked being the fix, right.
Man. What a choice that was...


You need to run cargo update in the local repo

That got me reproducing the install error, and let me set up a cli_install_fix_repro branch to test locally. Thanks for the direction on this!

There are a lot of legitimate build failures, more than are showing up in CI... I'll take a look at what it'll take to update manganis to use the new swc API, but it might take me a while to get done.

I've proven the fix with a local build. Nothing too bad.

@ealmloff
Copy link
Member

I pinned all of the swc_* crates that showed up in cargo tree. Should hopefully prevent more issues like this in the future

@ealmloff ealmloff enabled auto-merge (squash) August 29, 2024 14:32
@ealmloff ealmloff added the dependencies Pull requests that update a dependency file label Aug 29, 2024
@ealmloff ealmloff merged commit aeee8ff into DioxusLabs:main Aug 29, 2024
8 checks passed
@pyrrho pyrrho deleted the bump_pin_swc branch August 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not install [email protected] on WSL
2 participants