Fix issue where content of floating window is set to inactive #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to remove code that is setting the content of the floating window to inactive when the window becomes inactive.
This code was introduced in #410. The commit fixes an issue with activating the content, but it assumes that it should also deactivate the content. However, deactivating the content introduces new behavior. In our usage, this resulted in multiple issues, because we have child windows that popup and are no longer activating correctly because the parent floating window is no longer active.
To demonstrate the issue, I added a document with a button to open a simple message box to the TestApp. If you open the message box from a document docked in the main window, the document remains active (as shown by the blue tab and bar). However, when the document is in a floating window, opening the message box causes the document to become inactive. I would have expected the behavior to be th same in both cases.
Video of bug:
Here is a video of the fix. It also validates that the new code maintains the behavior of the original fix from #410.
