deps: Update @geometricpanda/storybook-addon-badges to v0.2.2 #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #678
Short description
This updates @geometricpanda/storybook-addon-badges to the latest version, because the previous version we were using has an older version of @storybook/theming as a dependency, which includes the non-React 18 compatible Emotion 10.
The interesting thing is that the newest version of addon-badges lists @storybook/[email protected] as a prod dependency without using theI've been looking at the wrong package.json the whole time in the repo. This is the correct one: https://github.com/geometricpanda/geometricpanda/blob/72ac16e6eb121480efccc426a4aac275d3b09b4d/libs/storybook-addon-badges/package.json#L40^
semver range, but once installed in Reactist, the semver symbol is included, allowing it to use v6.5.3 and deduped between other dependencies that use the theming package. I have no idea why this happened thoughThe only remaining package that pulls in Emotion 10 is addon-knobs, which will be removed with #677
How the badges are styled were deprecated as well, and has been updated to the new API (ref).
Test plan
npm run storybook
and check that the badges resembles the deployed docs at https://doist.github.io/reactist (it's by default positioned a little further away from the tabs which I thought looked better)PR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refnpm run build-all
)Versioning
No release needed