-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get completed items #90
Conversation
This would be very useful! I hope this library isn't REST API only since the Sync API still has useful endpoints such as activity logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks great, apart from the one comment I had. If it's addressed we can merge it. Thanks!
ca48a74
to
5a37ce4
Compare
Thank you for your review. I removed the docstrings and rebased this branch onto the latest main. |
thanks for merging this 🎉 |
@brunorosilva It's OK to use auxiliary API endpoints from the Sync API in this library. What we don't want is to use the You would need to wait for us to implement this in the REST API. CC @PotHix |
OK @lefcha , thanks for the info. |
It's useful if the client can get completed tasks. This PR implements
get_completed_items
that calls Get completed items API.Since it looks like models are migrating to use
dataclass
instead ofattrs
(#85), this PR also usesdataclass
to define models.Related to #32 and #56.