Try to sync the pending changes #32604
Conversation
Tested changes as of version 14.0.0
Based on code of V14.0.0. Added function used in later Segment.php
Hi Eldy.
You are right, {object_date} has the inmutable invoice date but the fact is that it is not available in the 'segment' file (or I was not able to find it) so I created the new function in the 'odf' file to retrieve it. It is the only modification to that file.
In the meantime you also are right that __CURRENTDAY__ should give the value relative to the current date to be consistent, not the one of the invoice. As I want, and need, the one on the invoice I have created a new block where 'CURRENT' has been changed by 'INVOICE' to build equivalents to the others (now relative to the current date) but relative to the invoice date.
Hope this clarifies the used tags and validate the changes.
Deleted extra parenthesis.
|
Did you send your changes into a PR ? Do you have the number ? |
eldy
added
the
Discussion
phpstan.neon.dist
Outdated
| - scripts | ||
| - dolibarr/htdocs | ||
| - dolibarr/scripts | ||
| - dolibarr/htdocs/core |
There was a problem hiding this comment.
You should not add this dir here, it is already include into dolibarr/htdocs.
I see no reason tomodify the phpstan.neon.dist for a change that is a feature enhancement.
There was a problem hiding this comment.
Those were suggestions by Git Copilot because I am were not able for many tries to make the pull request to get through the phpStan check. As I am not a very advanced user in Git, I did apply them blindly even though I also though that they were redundant.
I am trying to update the former code that is now not only obsolete, but wrong, and that I have to manually change every new version of Dolibarr is published making painful to apply updates. I know there are other users out there that also had issues with this code and I hope that, by applying the suggested changes, it will help them too.
To match the original file.
Match parameter name to definition
Make substitutionarray fully a compatible (string, string) array
I am not quite sure. Maybe this is the number: 32604? This what it show at the top: Try to sync the pending changes #32604 As told I am not quite good at managing this git thing. But I am learning. Sorry. |
FIX|Fix #2
This is a try to, again, sync the changes made years ago that never went into the main branch for whatever reason.
Pull request #1 is still ending and I do not know how to fix that. Please help with instructions.
Thanks.