FIX issue where clonned commandes had their last line moved anywhere #32670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line is not necessary and led the commande line table to have duplicates in it and made the clone of the command have the last line at the first place.
eldy
reviewed
Jan 15, 2025
| @@ -1706,7 +1706,6 @@ public function addline($desc, $pu_ht, $qty, $txtva, $txlocaltax1 = 0, $txlocalt | |||
|
|
|||
| if ($result > 0) { | |||
| $this->db->commit(); | |||
| $this->lines[] = $this->line; | |||
There was a problem hiding this comment.
I you remove this line, if order has 2 lines before adding the line, the order will stil have 2 lines after when it should have 3 lines.
Adding a resorting of lines would be better
For example by using $this->lines = dol_sort_array($this->lines, 'rang')
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning a commande would result in a mess of its lines position. When cloning the first time, the last line would become the first one and if a cloned commande was cloned again it would change again some position.