Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add signed url to gcs #23

Merged
merged 16 commits into from
Aug 12, 2024
Merged

feat: add signed url to gcs #23

merged 16 commits into from
Aug 12, 2024

Conversation

leonardoc-lima
Copy link
Contributor

Contain

  • New feature

Details

  • Add the signed URL creation module Google Cloud Storage to ensure access to the bucket.

@leonardoc-lima leonardoc-lima added the enhancement New feature or request label Jul 22, 2024
@leonardoc-lima leonardoc-lima requested a review from a team July 22, 2024 14:41
@leonardoc-lima leonardoc-lima self-assigned this Jul 22, 2024
julianolf
julianolf reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@julianolf julianolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Antes de seguir com estes PR da uma olhada nos comentários que deixei no seu outro PR.

Acho que tem coisas aqui que teriam que mudar.

@leonardoc-lima leonardoc-lima changed the base branch from feat/add-signed-url-to-s3 to main July 23, 2024 16:03
julianolf
julianolf reviewed Jul 23, 2024
View reviewed changes
cloud/google/storage.py Outdated Show resolved Hide resolved
cloud/google/storage.py Outdated Show resolved Hide resolved
cloud/google/storage.py Outdated Show resolved Hide resolved
tests/google/test_storage.py Outdated Show resolved Hide resolved
cloud/google/storage.py Outdated Show resolved Hide resolved
julianolf
julianolf reviewed Jul 24, 2024
View reviewed changes
cloud/google/storage.py Outdated Show resolved Hide resolved
@leonardoc-lima leonardoc-lima merged commit 391cae1 into main Aug 12, 2024
5 checks passed
@leonardoc-lima leonardoc-lima deleted the feat/add-signed-url-to-gcs branch August 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-f-santos gabriel-f-santos gabriel-f-santos left review comments

@julianolf julianolf julianolf approved these changes

Assignees

@leonardoc-lima leonardoc-lima

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonardoc-lima @julianolf @gabriel-f-santos