Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify lxml.etree import #397

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

a-kleinf
Copy link
Collaborator

Unified import via "from lxml import etree" (No tests or an update of the changelog is needed since no feature was implemented)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the changelog accordingly.
  • I have added tests to cover my changes.

@a-kleinf a-kleinf self-assigned this Nov 12, 2024
@a-kleinf a-kleinf linked an issue Nov 12, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 94.65241% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.85%. Comparing base (a55b40b) to head (aa5762a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/sdc11073/schema_resolver.py 81.81% 2 Missing ⚠️
src/sdc11073/xml_types/xml_structure.py 94.44% 2 Missing ⚠️
src/sdc11073/consumer/consumerimpl.py 50.00% 1 Missing ⚠️
src/sdc11073/namespaces.py 90.00% 1 Missing ⚠️
src/sdc11073/provider/porttypes/porttypebase.py 95.65% 1 Missing ⚠️
src/sdc11073/provider/subscriptionmgr_async.py 50.00% 1 Missing ⚠️
src/sdc11073/provider/subscriptionmgr_base.py 75.00% 1 Missing ⚠️
src/sdc11073/pysoap/soapclient.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   90.86%   90.85%   -0.02%     
==========================================
  Files         116      116              
  Lines       12963    12963              
==========================================
- Hits        11779    11777       -2     
- Misses       1184     1186       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-kleinf a-kleinf merged commit ba06944 into Draegerwerk:master Nov 14, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: change importing style of lxml etree
2 participants