cvm: A better way to remove orphans #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvinwang
force-pushed
the
safe-remove-orphans
branch
from
ecc57a3 to
1931ed6
Compare
kvinwang
force-pushed
the
safe-remove-orphans
branch
from
1931ed6 to
d45dea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation, the cvm ran
docker compose up --remove-orphans -don startup, where the --remove-orphans flag is to remove the containers no longer defined in the compose file after an upgrade.However, that's not enough. Although
--remove-orphansremoves the orphans, because it runs after the dockerd has started, the orphan containers would still run for a short period of time before being removed, if its RestartPolicy is always or so.This PR solves it by temporarily disabling the dockerd from being able to start containers in a hacked way:
chmod +x /usr/bin/containerd-shim-runc-v2before the dockerd starts. And recovering it after the docker compose has removed the orphans.