-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move socket functions to buddySocket file #744
base: main
Are you sure you want to change the base?
refactor: Move socket functions to buddySocket file #744
Conversation
@yuvrajinbhakti is attempting to deploy a commit to the dunsin's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, can you share a recording of the working software? With you chatting
client/src/App.jsx
Outdated
@@ -8,7 +8,7 @@ import NavBar from 'components/NavBar'; | |||
import NoPage from './pages/NoPage'; | |||
import Profile from './pages/Profile'; | |||
import ProtectedRoutes from 'components/ProtectedRoutes'; | |||
import ReactGA from 'react-ga4'; | |||
// import ReactGA from 'react-ga4'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please uncomment this
Fixes Issue
My PR closes #661
π¨βπ» Changes proposed(What did you do ?)
βοΈ Check List (Check all the applicable boxes)
βοΈ Check List
Note to reviewers