[DYN-6868] migrate to typeScript #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Jul 1, 2024
package.json
Outdated
| @@ -3,16 +3,16 @@ | |||
| "version": "1.0.15", | |||
There was a problem hiding this comment.
please bump up version always
|
@Enzo707 Did you get the chance to fix the unit tests? |
QilongTang
reviewed
Jul 8, 2024
src/components/LayoutContainer.tsx
Outdated
| import { Sidebar } from './Sidebar/Sidebar.jsx'; | ||
| import { useState } from 'react'; | ||
| import { MainContent } from '../components/MainContent'; | ||
| import { Sidebar } from '../components/Sidebar/Sidebar'; |
There was a problem hiding this comment.
Cant we import from the same folder?
There was a problem hiding this comment.
Sure, we can also implement an index file and import everything from feature folder or just from /components root:
import { MainContent } from './MainContent';
import { Sidebar } from './Sidebar';
Or
import { MainContent, Sidebar } from './';
There was a problem hiding this comment.
Thanks, @Enzo707 Would you update? I would like the import statements to be consistent
There was a problem hiding this comment.
@QilongTang I already updated the imports. PTAL
QilongTang
reviewed
Jul 8, 2024
src/components/MainContent.tsx
Outdated
| import { useState, useEffect } from 'react'; | ||
| import { RecentPage } from '../components/Recent/PageRecent'; | ||
| import { SamplesPage } from '../components/Samples/PageSamples'; | ||
| import { LearningPage } from '../components/Learning/PageLearning'; |
QilongTang
reviewed
Jul 8, 2024
| import { GridViewIcon, ListViewIcon } from '../Common/CustomIcons.jsx'; | ||
| import { openFile, saveHomePageSettings } from '../../functions/utility.js'; | ||
| import { GraphGridItem } from './GraphGridItem'; | ||
| import { CustomNameCellRenderer } from './CustomNameCellRenderer'; |
There was a problem hiding this comment.
We are able to import from the folder here?
QilongTang
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for migrating DynamoHome from js to typeScript as a first step before adding test coverage.
Ref.: DYN-6868
Review
@QilongTang
@dnenov