i#1973 musl: Add CI workflow #7197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow constructs an Alpine Linux chroot environment in place and build DynamoRIO in it, serving as compatibility verification against musl. Tests are disabled in CI since only half of them pass. Issue: DynamoRIO#1973
derekbruening
requested review from
abhinav92003
and removed request for
derekbruening
abhinav92003
approved these changes
Jan 21, 2025
| if (UNIX AND NOT APPLE AND "$ENV{DYNAMORIO_CLANG}" MATCHES "yes") | ||
| set(run_tests OFF) | ||
| message("Detected a CI clang suite: disabling running of tests") | ||
| # XXX i#1973: our musl port passes only half of the tests. Enable tests in CI |
There was a problem hiding this comment.
Perhaps this should be a TODO not an XXX.
| # fortify-headers, which isn't compatible with DynamoRIO source. | ||
| # TODO i#1973: simplify after fixing compatibility problem. | ||
| sudo sbin/apk.static -p alpine-root -U --initdb --allow-untrusted add \ | ||
| alpine-base binutils bash cmake doxygen file g++ git libunwind-dev \ |
There was a problem hiding this comment.
Which of these need --allow-untrusted? Add that to comment?
There was a problem hiding this comment.
It's necessary because we're creating a rootfs from scratch, thus there isn't any public key available to verify package signatures. I consider it acceptable since we're downloading packages through https (see the repository configuration)
Will add a comment on this.
| echo "https://dl-cdn.alpinelinux.org/v3.21/main/" | \ | ||
| sudo tee alpine-root/etc/apk/repositories | ||
| # Meta-package build-base simplifies dependencies, but it pulls in | ||
| # fortify-headers, which isn't compatible with DynamoRIO source. |
There was a problem hiding this comment.
Could you augment this comment with some more details:
- What do you mean "not compatible with DynamoRIO source"?
- What is the simplification suggested?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow constructs an Alpine Linux chroot environment in place and build DynamoRIO in it, serving as compatibility verification against musl. Tests are disabled in CI since only half of them pass.
Issue: #1973