i#7199: make adding a new register less error-prone #7200
+46
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently easy to miss an important step when adding a new register, as the value of the last register is marked by two alias enums that have to be maintained. Add a new enum `DR_REG_AFTER_LAST_VALID_ENUM` to mark the end of the actual registers. This means we can avoid using aliases. Fixes: #7199
|
Will fix the Windows build and push again (hopefully tomorrow.) |
derekbruening
requested changes
Jan 21, 2025
…backwards compatibility
…moRIO/dynamorio into i#7199-make-adding-registers-easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently easy to miss an important step when adding a new register, as the value of the last register is marked by two alias enums that have to be maintained.
Add a new enum
DR_REG_AFTER_LAST_VALID_ENUMto mark the end of the actual registers. This means we can avoid using aliases.Fixes: #7199