i#2154 Android64: Get tests building #7201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made some tweaks to the CMake scripts to get the test suite building for Android: - Drmemtrace is not currently built for Android so we need to disable some tests which depend on it when building for Android (rseq). - Disable linux.infloop test because we don't currently build the test binary for Android. - Changed to --dynamic-list because --dynamic-list-data is not supported by lld which is the linker now used in the Android ndk. It should now be possible to build for Android64 with -DBUILD_TESTS=ON using the latest Android ndk (tested with r27c). Issues: #2154, #1874
derekbruening
requested changes
Jan 21, 2025
derekbruening
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some tweaks to the CMake scripts to get the test suite building for Android:
Drmemtrace is not currently built for Android so we need to disable some tests which depend on it when building for Android (rseq).
Build linux.infloop test binary because it compiles fine for Android and other CMake code expects the target to exist.
Removed --dynamic-list-data because it is not needed with the latest NDK toolchains.
Copy
run_in_bgtool to the Android test device because it is needed by some tests.It should now be possible to build for Android64 with -DBUILD_TESTS=ON using the latest Android ndk (tested with r27c).
Issues: #2154, #1874