Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing image #6

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Update testing image #6

merged 1 commit into from
Feb 10, 2025

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Feb 7, 2025

Description

Updates the testing image to have an ENRTYPOINT, the same way as is expected in prod images

How can this be tested?

Added a sample.yaml, to test current and future features. Just have to update the image field accordingly

@0sewa0
Update testing image
ae90531 
according to what is expected in prod images
@0sewa0 0sewa0 requested a review from a team as a code owner February 7, 2025 10:34
@0sewa0 0sewa0 mentioned this pull request Feb 7, 2025
Merged
waodim
waodim approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@waodim waodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! tested it several times, works, especially the sample.yaml is pretty handy 👍

@0sewa0 0sewa0 merged commit 2f2755c into main Feb 10, 2025
6 checks passed
@0sewa0 0sewa0 deleted the testing/add-entrypoint branch February 10, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waodim waodim waodim approved these changes

@andriisoldatenko andriisoldatenko Awaiting requested review from andriisoldatenko andriisoldatenko is a code owner automatically assigned from Dynatrace/kubernetes-operator

@gkrenn gkrenn Awaiting requested review from gkrenn gkrenn is a code owner automatically assigned from Dynatrace/kubernetes-operator

@chrismuellner chrismuellner Awaiting requested review from chrismuellner chrismuellner is a code owner automatically assigned from Dynatrace/kubernetes-operator

@StefanHauth StefanHauth Awaiting requested review from StefanHauth StefanHauth is a code owner automatically assigned from Dynatrace/kubernetes-operator

@aorcholski aorcholski Awaiting requested review from aorcholski aorcholski is a code owner automatically assigned from Dynatrace/kubernetes-operator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0sewa0 @waodim