Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] Add OneAgent version validator #3967

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

albertogdd
Copy link
Contributor

@albertogdd albertogdd commented Oct 23, 2024

Description

https://dt-rnd.atlassian.net/browse/DAQ-1817

Same as #3966

But adding the validator also for beta1 (because different apiVersion validators are only merged on main)

How can this be tested?

Only DynaKubes with versions like this should pass the CR validation when applying:

spec:
  oneAgent:
    cloudNativeFullStack:
      version: 1.304.0.20240826-070516

⚠️ Test on v1beta1 and v1beta2

@albertogdd albertogdd added the bug Something isn't working label Oct 23, 2024
@albertogdd albertogdd changed the base branch from main to release-1.3 October 23, 2024 11:27
@albertogdd albertogdd marked this pull request as ready for review October 23, 2024 11:29
@albertogdd albertogdd requested a review from a team as a code owner October 23, 2024 11:29
@albertogdd albertogdd requested review from gkrenn, 0sewa0, chrismuellner, waodim, StefanHauth, aorcholski and luhi-DT and removed request for a team October 23, 2024 11:29
@albertogdd albertogdd changed the title Cherry pick [v.1.3] 'Add OneAgent version validator' Cherry pick [v1.3] 'Add OneAgent version validator' Oct 23, 2024
@albertogdd albertogdd changed the title Cherry pick [v1.3] 'Add OneAgent version validator' [release-1.3] Add OneAgent version validator Oct 23, 2024
@albertogdd albertogdd enabled auto-merge (squash) October 23, 2024 11:53
@albertogdd albertogdd disabled auto-merge October 23, 2024 12:19
@albertogdd albertogdd enabled auto-merge (squash) October 23, 2024 12:19
@luhi-DT luhi-DT closed this Oct 23, 2024
auto-merge was automatically disabled October 23, 2024 12:26

Pull request was closed

@luhi-DT luhi-DT reopened this Oct 23, 2024
@albertogdd albertogdd enabled auto-merge (squash) October 23, 2024 12:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.30%. Comparing base (255dc3f) to head (1606bac).
Report is 1 commits behind head on release-1.3.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.3    #3967      +/-   ##
===============================================
+ Coverage        64.26%   64.30%   +0.03%     
===============================================
  Files              353      353              
  Lines            23719    23737      +18     
===============================================
+ Hits             15244    15265      +21     
+ Misses            7222     7219       -3     
  Partials          1253     1253              
Flag Coverage Δ
unittests 64.30% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertogdd albertogdd merged commit 04ea135 into release-1.3 Oct 23, 2024
14 checks passed
@albertogdd albertogdd deleted the bug/release-1.3/oa-version-validation branch October 23, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants