Move collector service account template to separate collector …

[andriisoldatenko]

Description

This PR moves/renames extension-collector service account and cluster role, since we will use it NOT only with extensions.

resolves Issue DAQ-3329

How can this be tested?

1. Deploy operator 1.4.0

helm upgrade dynatrace-operator oci://public.ecr.aws/dynatrace/dynatrace-operator \
  --version 1.4.0 \
  --create-namespace --namespace dynatrace \
  --install \
  --atomic

2. Upgrade using this branch:

Assuming you have built image/or use CI one:

helm upgrade dynatrace-operator config/helm/chart/default \
                        --install \
                        --namespace dynatrace \
                        --create-namespace \
                        --atomic \
                        --set installCRD=true \
                        --set csidriver.enabled=true \
                        --set manifests=true \
                        --set image="quay.io/dynatrace/dynatrace-operator:snapshot-rename-collector-sa"

3. Make sure everything is running; check the list of SA/ClusterRoles and bindings to make sure there are no old leftovers.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.18%. Comparing base (f00e14a) to head (092e79b).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4312   +/-   ##
=======================================
  Coverage   64.18%   64.18%           
=======================================
  Files         401      401           
  Lines       26327    26327           
=======================================
  Hits        16897    16897           
  Misses       8125     8125           
  Partials     1305     1305           

Flag	Coverage Δ
unittests	64.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[0sewa0]

LGTM, just few comments:

• do we need to consider the users who use manifests directly?
• do marketplaces handle this gracefully?

nitpick:

• Adding a [Helm] prefix to the title is unnecessary, we even have a label for Helm 😅

[andriisoldatenko]

nitpick:
Adding a [Helm] prefix to the title is unnecessary, we even have a label for Helm 😅
@0sewa0 fixed - it was copy pasta from jira ticket description, my bad :(

[andriisoldatenko]

do we need to consider the users who use manifests directly?
do marketplaces handle this gracefully?

that's a fair point, @StefanHauth. Could you please answer on it?

[waodim]

lgtm, i will approve if the 2 remaining questions are answered

[StefanHauth]

• do we need to consider the users who use manifests directly?

This should be well covered in release notes and made very clear that some manual cleanup might be necessary.