-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug messages to CSI identity services handlers (main branch) #4355
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4355 +/- ##
==========================================
- Coverage 64.29% 64.29% -0.01%
==========================================
Files 402 402
Lines 26481 26483 +2
==========================================
Hits 17027 17027
- Misses 8145 8147 +2
Partials 1309 1309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adb15a2
to
cbdd3e9
Compare
pkg/controllers/csi/driver/server.go
Outdated
@@ -141,14 +141,20 @@ func (srv *Server) Start(ctx context.Context) error { | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a comment left unanswered in the other PR which also sparks my interest tbh:
Could someone answer that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probe
request is sent every few seconds and is not rejected by Server rate limiter so we will see confirmation
the Server process is running in a given period of time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to have this explanation inside the comment before the debug log. It will simplify future maintenance IMO.
cbdd3e9
to
54b1a73
Compare
54b1a73
to
40d07b4
Compare
JIRA
PR for release-1.4
Description
Adds debug messages to the CSI Server handlers
How can this be tested?
Add
LOG_LEVEL=debug
environment variable to the CSI Server container and check logs.