Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug messages to CSI identity services handlers (main branch) #4355

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aorcholski
Copy link
Contributor

JIRA

PR for release-1.4

Description

Adds debug messages to the CSI Server handlers

  • GetPluginCapabilities
  • GetPluginInfo
  • Probe

How can this be tested?

Add LOG_LEVEL=debug environment variable to the CSI Server container and check logs.

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.29%. Comparing base (8cccb6a) to head (40d07b4).

Files with missing lines Patch % Lines
pkg/controllers/csi/driver/server.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4355      +/-   ##
==========================================
- Coverage   64.29%   64.29%   -0.01%     
==========================================
  Files         402      402              
  Lines       26481    26483       +2     
==========================================
  Hits        17027    17027              
- Misses       8145     8147       +2     
  Partials     1309     1309              
Flag Coverage Δ
unittests 64.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aorcholski aorcholski force-pushed the feature/csi-dbg-msgs-main branch from adb15a2 to cbdd3e9 Compare January 27, 2025 10:27
@@ -141,14 +141,20 @@ func (srv *Server) Start(ctx context.Context) error {
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a comment left unanswered in the other PR which also sparks my interest tbh:

#4353 (review)

Could someone answer that?

Copy link
Contributor Author

@aorcholski aorcholski Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probe request is sent every few seconds and is not rejected by Server rate limiter so we will see confirmation
the Server process is running in a given period of time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have this explanation inside the comment before the debug log. It will simplify future maintenance IMO.

@aorcholski aorcholski force-pushed the feature/csi-dbg-msgs-main branch from cbdd3e9 to 54b1a73 Compare January 27, 2025 17:22
@aorcholski aorcholski force-pushed the feature/csi-dbg-msgs-main branch from 54b1a73 to 40d07b4 Compare January 28, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants