Fix OneAgent command line arguments #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanHauth
requested review from
andriisoldatenko,
gkrenn,
0sewa0,
chrismuellner,
waodim and
aorcholski
and removed request for
a team
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-1.4 #4357 +/- ##
===============================================
+ Coverage 64.17% 64.19% +0.02%
===============================================
Files 401 401
Lines 26978 26999 +21
===============================================
+ Hits 17312 17333 +21
Misses 8299 8299
Partials 1367 1367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0sewa0
reviewed
Jan 27, 2025
|
@StefanHauth still linting is failing |
0sewa0
reviewed
Jan 27, 2025
0sewa0
approved these changes
Jan 28, 2025
StefanHauth
added a commit
that referenced
this pull request
Jan 28, 2025
StefanHauth
added a commit
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiple occasions of command line arguments for OneAgent shall be avoided. Exceptions are only
--set-host-propertyand--set-host-tag. Host tags shall not be provided multiple times with the same value.How can this be tested?
Deploy a Dynakube with custom OneAgent arguments and make sure that the custom arguments take precedence in the OneAgent daemon set and that no duplications show up (besidd the exceptions)
JIRA