Cherry-pick: Reject dynakubes that use public image and not read only oneAgent #4346 #4386
Conversation
waodim
added
the
cherrypick
waodim
requested review from
andriisoldatenko,
gkrenn,
0sewa0,
chrismuellner,
StefanHauth and
aorcholski
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4386 +/- ##
=======================================
Coverage 64.36% 64.37%
=======================================
Files 402 402
Lines 26554 26559 +5
=======================================
+ Hits 17092 17097 +5
Misses 8151 8151
Partials 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -23,6 +23,8 @@ Use a nodeSelector to avoid this conflict. Conflicting DynaKubes: %s` | |||
|
|
|||
| errorVolumeStorageReadOnlyModeConflict = `The DynaKube specification specifies a read-only host file system while OneAgent has volume storage enabled.` | |||
|
|
|||
| errorPublicImageWithWrongConfig = `The DynaKube specification specifies a custom (and therefor probably a public) image in combination with a mode that needs write permissions for volume mounts.` | |||
There was a problem hiding this comment.
| errorPublicImageWithWrongConfig = `The DynaKube specification specifies a custom (and therefor probably a public) image in combination with a mode that needs write permissions for volume mounts.` | |
| errorPublicImageWithWrongConfig = `The DynaKube specification specifies a custom (most likely public) image in combination with a mode that needs write permissions for volume mounts.` |
There was a problem hiding this comment.
I think the information in the warning is confusing and incorrect: #4346 (comment)
There was a problem hiding this comment.
Well I agree to be honest it may be a little too technical
There was a problem hiding this comment.
Changed it to @chrismuellner 's suggestion as I like it and it is correct: 9cd3a62
Now if my prev. wording is wrong we probably should also change it on the release branch right?
Description
same as #4346
How can this be tested?
same as in #4346