Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds possibility to enable Live Debugger module in ActiveGate. #4407

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

StefanHauth
Copy link
Collaborator

Description

Add capability debugging to the list of known ActiveGate capabilities.

How can this be tested?

Deploy a DynaKube where debugging is enabled in ActiveGate:

  activeGate:
    capabilities:
      - routing
      - kubernetes-monitoring
      - dynatrace-api
      - metrics-ingest
      - debugging

Check the ActiveGate pod manifest:

  containers:
  - env:
    - name: DT_CAPABILITIES
      value: MSGrouter,kubernetes_monitoring,restInterface,metrics_ingest,debugging,extension_controller

Look for the follwing ActiveGate log lines:

activegate 2025-02-04 17:37:37 UTC INFO    [<exq67461>] [<live_debugging>, LDModule] Initializing Live Debugging module
activegate 2025-02-04 17:37:37 UTC INFO    [<exq67461>] [<live_debugging>, LDModule] onClusterRuntimeInfoUpdated has not been called yet and upstreamInfoProvider is not ready, not declaring readiness
activegate 2025-02-04 17:37:39 UTC INFO    [<exq67461>] [<collector.modules>, ModulesManager] debugging module is ready.

@StefanHauth StefanHauth added the activegate Changes related to Activegate label Feb 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.37%. Comparing base (1acc9e7) to head (9a30db1).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4407      +/-   ##
==========================================
+ Coverage   64.36%   64.37%   +0.01%     
==========================================
  Files         402      402              
  Lines       26554    26562       +8     
==========================================
+ Hits        17092    17100       +8     
  Misses       8151     8151              
  Partials     1311     1311              
Flag Coverage Δ
unittests 64.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@waodim waodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

│ activegate 2025-02-05 10:11:23 UTC INFO    [<asj34817>] [<live_debugging>, LDModule] Initializing Live Debugging module                                                                                          │
│ activegate 2025-02-05 10:11:23 UTC INFO    [<asj34817>] [<live_debugging>, LDModule] onClusterRuntimeInfoUpdated has not been called yet and upstreamInfoProvider is not ready, not declaring readiness          │
│ activegate 2025-02-05 10:11:24 UTC INFO    [<asj34817>] [<collector.modules>, ModulesManager] debugging module is ready.

Everything seems to be here. lgtm

@StefanHauth StefanHauth enabled auto-merge (squash) February 5, 2025 10:57
@StefanHauth StefanHauth merged commit fcac2b4 into main Feb 5, 2025
14 checks passed
@StefanHauth StefanHauth deleted the feature/ag-debugging-capability branch February 5, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activegate Changes related to Activegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants