Mount telemetryService.TlsRefName secret to OtelC POD

[aorcholski]

JIRA

Description

Mounts TLS secret to OtelC POD.

extensions-collector POD is restarted if the secret is changed (added ts-secret-hash template annotation).

How can this be tested?

1. unittests
2. dynakube

create secret

openssl req -nodes -x509 -newkey rsa:4096 -keyout key.pem -out crt.pem -days 5 -subj "/CN=test"
kctl create secret tls ts --cert=crt.pem --key=key.pem

deploy dynakube

  apiUrl: ...
  activeGate:
    capabilities:
    - kubernetes-monitoring
  extensions: {}
  customPullSecret: ...
  telemetryService:
    tlsRefName: ts
  templates:
    extensionExecutionController:
      imageRef:
        repository: ...
        tag: ...

check dynakube-extensions-collector-0 spec.volumes

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.60870% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.43%. Comparing base (fcac2b4) to head (a64df72).

Files with missing lines	Patch %	Lines
...ntrollers/dynakube/otelc/statefulset/reconciler.go	55.55%	6 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4412      +/-   ##
==========================================
+ Coverage   64.37%   64.43%   +0.05%     
==========================================
  Files         402      402              
  Lines       26562    26602      +40     
==========================================
+ Hits        17100    17141      +41     
+ Misses       8151     8148       -3     
- Partials     1311     1313       +2     

Flag	Coverage Δ
unittests	64.43% <82.60%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[StefanHauth]

Suggested change

	AnnotationTelemetryServiceSecretHash = InternalFlagPrefix + "ts-secret-hash"
	AnnotationTelemetryServiceSecretHash = InternalFlagPrefix + "telemetry-service-secret-hash"

[StefanHauth]

Should this be also conditional, only if extension are enabled?

[StefanHauth]

Suggested change

	AnnotationSecretHash = InternalFlagPrefix + "secret-hash"
	AnnotationExtensionsSecretHash = InternalFlagPrefix + "extensions-secret-hash"

[0sewa0]

+1 to this, as it is only used for extensions

maybe the location of the const is not the best(veeery general location)