Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Wave Momentum Coupling #104

Conversation

erinethomas
Copy link

NEW WAVE MOMENTUM COUPLING FEATURE
Full momentum coupling between WW3, MPAS-Ocean, and EAM is being implemented.
This discussion is for the purpose of getting a preliminary code review and feedback before an official PR is opened into E3SM.
This PR uses COARE3.0 flux calculation which is needed for wave coupling to atmosphere via charnock parameter.

A table summarizing all testing being performed is at the bottom of the page here:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4271702034/2024.Q2+WAVEWATCH+III+maintenance+developments
Suggestions welcome for additional testing that is needed to open a PR into E3SM.
a 100 year Fully coupled Simulation is currently being done.

The use of WW3 is 'stealth' in that WW3 is NOT a standard component of E3SM for production runs. However, the implementation of wave-ocean-atm coupling in this PR defines the default coupling based upon the COMPSET used.
For example, a fully coupled base with active waves (B compset + WW3) will assume full, two-way coupling between WW3-EAM-MPASO and MPAS-SI. (note: limited wave-ice coupling for now, full wave-ice coupling coming in near future). On the other hand, if a data atmosphere used, like in a G Case+WW3, EAM-WW3 coupling will default to "one-way" (data winds passed to WW3) while full two way coupling is used between the active components of WW3 and MPAS-O/MPAS-SI.

@erinethomas
Copy link
Author

@OlawaleClimate

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 139: Add comment about cor30a-wav

@erinethomas erinethomas force-pushed the WaveMomentumCoupling branch from bc5368e to e0f6b26 Compare July 10, 2024 20:45
lines.append('<stream name="timeSeriesStatsDailyWaveOutput"')
lines.append(' type="output"')
lines.append(' precision="single"')
lines.append(' io_type="pnetcdf"')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a discussion with @sbrus89 suggest changing the io_type toio_type="{}"'.format(ocn_pio_typename)

@erinethomas erinethomas force-pushed the WaveMomentumCoupling branch from 2a838fd to 9b7fe62 Compare August 8, 2024 15:34
@erinethomas erinethomas force-pushed the WaveMomentumCoupling branch 3 times, most recently from d6eb466 to 1d22ac1 Compare November 6, 2024 21:45
@xylar xylar changed the base branch from master to alternate December 18, 2024 17:45
@xylar xylar changed the base branch from alternate to master December 18, 2024 17:45
@xylar
Copy link
Collaborator

xylar commented Dec 18, 2024

@erinethomas, a small thing and not what you really need here but I updated the master branch here on Ocean-Discussion and then did a quick swap so this PR noticed the update. That should at least make it easier to look over the code changes.

@erinethomas
Copy link
Author

@xylar - thanks - that works for me.

@proteanplanet
Copy link
Collaborator

@erinethomas If not yet available, suggest running a short simulation (10-year) as soon as possible in the New Year, and then submitting as final PR if you are ready. You'll need to demonstrate, of course, that it is BFB without waves switched on.

@erinethomas
Copy link
Author

Closing PR in Ocean Discussion. PR opened to E3SM Master (E3SM-Project#6943)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants