New spatially-variable horizontal upwind capability #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NBFB-bug' (PR E3SM-Project#6942) The MAM4xx microphysics standalone test shows NBFB behavior for two consecutive runs on GPUs. This PR fixes that, and all the fixes are in the MAM4xx submodule. This PR also fixes an issue related to the LINOZ file read in the microphysics interface. The time dimension in the LINOZ file is not unlimited. Adding a function call to pretend_dim_is_unlimited fixes this issue. [non-BFB] only for EAMxx
TestingParabolic bowl test has been run and found to have similar convergence and error. Drying slope testing in progress; fixing bug in Compass. Global ocean standalone testing planned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we add a new capability to transition between centered and upwinded horizontal thickness advection as a function of column thickness.
Formerly, either thickness advection was centered or upwinded everywhere. With this PR, when
config_use_spatially_variable_upwindingis.true., advection is fully upwinded when the column thickness is less thanconfig_spatially_variable_upwind_hminand fully centered when column thickness is greater thanconfig_spatially_variable_upwind_hmax. Between these values, there is a linear transitionlayerThickEdgeFlux